Upgradeable contract is missing a gap storage variable
Summary
The missing gap storage variable in upgradeable contracts, like in the SDLPool.sol file, is a vulnerability that limits future flexibility and can lead to storage collisions or incompatibilities if the contract is upgraded or extended.
Vulnerability Details
If a contract is extended, a gap storage variable will allow to freely add new state variables in the future, without compromising the storage compatibility with existing deployments.
Impact
Without gap storage variables, upgrading the contract can lead to storage collisions, which can corrupt the contract's state, lead to loss of data, or make the contract behave unpredictably.
Tools Used
Manual review
Recommendations
Add gap storage
Lead Judging Commences
storage-gap
Lack of storage gaps in SDLPool might impact storage of SDLPoolPrimary and SDLPoolSecondary if new storage introduced in future.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.