Summary

Large approvals may not work with some ERC20 tokens

Vulnerability Details

Not all IERC20 implementations are totally compliant, and some (e.g UNI, COMP) may fail if the valued passed to approve is larger than uint96. If the approval amount is type(uint256).max, which may cause issues with systems that expect the value passed to approve to be reflected in the allowances mapping.

Impact

If the approval amount is type(uint256).max, which may cause issues with systems that expect the value passed to approve to be reflected in the allowances mapping.

Tools Used

Manual Review

Recommendations

Check if token is compliant with type(uint256).max