Submission Details
Severity:
Upgradeable contract is missing a `__gap[50]` storage variable to allow for new storage variables in later versions
Summary
Upgradeable contract is missing a __gap[50] storage variable to allow for new storage variables in later versions
Vulnerability Details
See this link for a description of this storage variable. While some contracts may not currently be sub-classed adding the variable now protects against forgetting to add it in the future
Impact
Instances (3):
File: contracts/core/sdlPool/SDLPoolPrimary.sol
11: contract SDLPoolPrimary is SDLPool {
File: contracts/core/sdlPool/SDLPoolSecondary.sol
11: contract SDLPoolSecondary is SDLPool {
File: contracts/core/sdlPool/base/SDLPool.sol
15: contract SDLPool is RewardsPoolController, IERC721Upgradeable, IERC721MetadataUpgradeable {
Tools Used
Recommendations
Updates
Lead Judging Commences
0kage over 1 year ago
Submission Judgement Published Assigned finding tags:
storage-gap
Lack of storage gaps in SDLPool might impact storage of SDLPoolPrimary and SDLPoolSecondary if new storage introduced in future.
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.