stake.link

Summary

In contract SDLPoolPrimary.sol, the function handleIncomingRESDL() doesn't update lastLockId. In the case of the param _lockId is bigger than lastLockId, there should be update of lastLockId.

Vulnerability Details

lastLockId is used in many places through the codebase. Without correct update, the whole functionality of code is going to be affected. Similarly The same update should be done if _lockId is equal to lastLockId in function handleOutgoingRESDL().

Impact

All parts use lastLockId will be affected due to unupdated lastLockId

Tools Used

Manual Analysis

Recommendations

Put a check that controls whether the param _lockİd is equal to lastLockId