timelock for function have key variables
Summary
No timelock for functions of setMaxLockingDuration and setMaxBoost that have key functionalities.
Vulnerability Details
LinearBoostController have setMaxLockingDuration and setMaxBoost functions that sets important value but does not have any protection against setting values at discretion of Owner.
It is a good practice to give time for users to react and adjust to critical changes. A timelock provides more guarantees and reduces the level of trust required, thus decreasing risk for users.
Impact
The owner could call the functions whenever he wants with no context of notifying the users or giving them time to react.
Tools Used
Manual Analysis
Recommendations
Add a timelock to functions of setMaxLockingDuration and setMaxBoost of LinearBoostController contract .
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.