Submission Details
Severity:
State changing functions lacks Event emissions in SDLPool.sol
Summary
State changing functions lacks Event emissions.
Vulnerability Details
Certain functions in the SDLPool don't emit events for parameters change of the protocol. These are the contexts shown below:
Context: SDLPool.sol
function setBoostController(address _boostController) external onlyOwner {
boostController = IBoostController(_boostController);
// @audit no event emission.
}
Context: SDLPool.sol
function setCCIPController(address _ccipController) external onlyOwner {
ccipController = _ccipController;
// @audit no event emission.
}
Context: SDLPool.sol
function setBaseURI(string calldata _baseURI) external onlyOwner {
baseURI = _baseURI;
}
Impact
Not adding an event will not facilitate off-chain monitoring when changing system parameters.
Tools Used
Manual Review
Recommendations
Make sure these endpoints emit events as some off-chain agents might be monitoring the protocol for these events.
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.