Relevant GitHub Links

https://github.com/Cyfrin/2023-12-stake-link/blob/549b2b8c4a5b841686fceb9c311dca9ac58225df/contracts/core/ccip/base/SDLPoolCCIPController.sol#L52-L53

Summary

The contract grants maximum possible allowances (type(uint256).max) of LinkToken and SDLToken to the _router. This practice can lead to catastrophic consequences if the _router is compromised. Attackers could exploit this unlimited access to drain funds from the contract.

Vulnerability Details

Code snippets:

Impact

A compromised _router could drain the entire contract's holdings of LinkToken and SDLToken.

Tools Used

Manual Review

Recommendations

Modify the code to approve only the exact amounts of tokens required for specific transactions.