MorpheusAI

Summary

Risk of silent overflow

Vulnerability Details

In the L2TokenReceiver.sol collectFees(),the uint256 amount0_, amount1_ is forcefully cast to uint128.
In the 2023-07-PoolTogether contest on C4, there is relevant and valid finding for this issue. You can find it here: https://code4rena.com/reports/2023-07-pooltogether#m-19-silent-overflow-could-alter-computation-when-calculating-the-vaultportion-in-the-prizepool-contract

Impact

This can potentially result in a silent overflow and may lead to amount0_, amount1_ goes wrong.

Tools Used

Recommendations

Add checks that the casting value is not greater than the uint128 type max value