MorpheusAI

Summary

In Distribution::createPool.sol the function is used to create a pool by a user . But after a pool creation the pool Id is not returned or updated or emitted.

Vulnerability Details

Usually a user will search for a specific pool using the specific pool Id. As there will be a bunch of pool is going to be created it would be a problem for the user to find out their desired pool.

Impact

After pool creation with createPool the user would face difficulty in calling the function editPool without the exact pool id.

Tools Used

Manual Analysis

Recommendations

Update the pool Id in the array as it is shown in editPool function after pool creation (https://github.com/Cyfrin/2024-01-Morpheus/blob/07c900d22073911afa23b7fa69a4249ab5b713c8/contracts/Distribution.sol#L82-L96)