MorpheusAI

MorpheusAI
Foundry
22,500 USDC
View results
Submission Details
Severity: low
Invalid

Duplicate Pools can be created

Summary

In the createPool we have no check to ensure we do not create a pool similar to one that already exists

function createPool(Pool calldata pool_) public onlyOwner {
require(pool_.payoutStart > block.timestamp, "DS: invalid payout start value");
_validatePool(pool_);
pools.push(pool_);
emit PoolCreated(pools.length - 1, pool_);
}

Recommendations

Before pushing the newly created pool to the array consider checking that the pool does not already exist

// Check if a similar pool already exists
require(!_poolExists(pool_), "DS: pool already exists");
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.