MorpheusAI

Summary

When calling approve, transfer or transferFrom it's good practice to check the return values of the fuction in case it didn't succeed (depending on the token in question).

Vulnerability Details

Usually when something goes wrong in these functions the transaction is reverted though in some tokens it will only return false.

Impact

This could lead to attackers taking advantage of this in order to make the contract think tokens were deposited while they were not, resulting in loss of tokens for the contract when the attacker claims his tokens.

Tools Used

VSCodium

Recommendations

check the return value of the function or use SafeERC20 to catch all the possible scenarios.