MorpheusAI

Summary

Access, admin and onlyOwner functionality missing events

Vulnerability Details

function manageUsersInPrivatePool(
uint256 poolId_,
address[] calldata users_,
uint256[] calldata amounts_
) Distribution.sol does not emit event

function removeUpgradeability() external onlyOwner ... Distribution.sol does not emit event

function setDistribution(address distribution_) public onlyOwner ... L1Sender.sol does not emit event

function setRewardTokenConfig(RewardTokenConfig calldata newConfig_) public onlyOwner ... L1Sender.sol does not emit event

function setDepositTokenConfig(DepositTokenConfig calldata newConfig_) public onlyOwner { ...L1Sender.sol does not emit event

function setParams(address rewardToken_, Config calldata config_) external onlyOwner ....L2MessageReceiver.sol does not emit event

function editParams(SwapParams memory newParams_) external onlyOwner ...L2TokenReceiver.sol does not emit event

Impact

Events are critical for offchain monitoring, real time monitoring, offchain reporting, security and more. It is critical and best practise these functions emit events

Tools Used

Manual Analysis

Recommendations

Emit events for all admin, access controlled, onlyOwner functionality for offchain reporting, monitoring, tracking, security purposes