MorpheusAI

MorpheusAI
Foundry
22,500 USDC
View results
Submission Details
Severity: low
Invalid

The bridgeOverplus function doesn't emit an event. an event emission could enhance transparency and facilitate tracking of bridging events

Summary

The bridgeOverplus function in the provided contract lacks an event emission. Adding an event emission for the OverplusBridged event after the successful execution of the bridging operation can enhance transparency and facilitate tracking of bridging events.

Vulnerability Details

The absence of an event emission in the bridgeOverplus function means that there is no log of the bridging operation in the contract's event history. Events play a crucial role in providing transparency, allowing external systems to track and react to important contract activities.

Impact

The lack of an event emission in the bridgeOverplus function hinders the ability to monitor and analyze bridging activities on the blockchain. This can limit transparency and make it challenging to detect or react to the bridging of overplus.

Tools Used

Manual code review.

Recommendations and Mitigation Steps

To address this issue, consider adding an event emission at the end of the bridgeOverplus function to log relevant information about the bridging operation. Here's an example modification:

By emitting the OverplusBridged event, you provide a clear record of the bridging operation on the blockchain, enhancing transparency and facilitating external tracking systems.

event OverplusBridged(uint256 amount, bytes uniqueId);
function bridgeOverplus(
uint256 gasLimit_,
uint256 maxFeePerGas_,
uint256 maxSubmissionCost_
) external payable returns (bytes memory) {
// Existing code for bridging operation
// Emitting OverplusBridged event
emit OverplusBridged(msg.value, uniqueId);
// ...
}
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.