Submission Details
Severity:
'GatewayRouterMock.sol' and 'SwapRouterMock.sol' don't check the return upon transfer IERC20
Summary
Vulnerability Details
In the L1Sender.sol the sendDepositsToken use the mock ' IGatewayRouter(config.gateway).outboundTransfer' which as we can see doesn't check the return which can cause the unintended and unpleasant consequences during function process.
The same issue is in the L2TokenReceiver.sol in the swap function the 'ISwapRouter.ExactInputSingleParams' doesn’t check the return.
Impact
The transfer can be failed without being noticed by the calling contract.
Tools Used
Manual review
Recommendations
Use SafeERC20 library on both functions
Updates
Prize pool breakdown
Total prize
22,500 USDC
nSLOC
1,05421 USDC / LOC
20,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.