Summary

Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom

Vulnerability Details

Impact

It is good to add a require() statement that checks the return value of token transfers or to use something like OpenZeppelin’s safeTransfer/safeTransferFrom unless one is sure the given token reverts in case of a failure. Failure to do so will cause silent failures of transfers and affect token accounting in contract.

Tools Used

Manual Review

Recommendations

Consider using safeTransfer/safeTransferFrom or require() consistently.