Summary

In the external function signature, the parameter names are depositTokenAmountAdd_ and rewardTokenAmountAdd_, while in the internal part of the function, are used amountAdd0_ and amountAdd1_.

Vulnerability Details

In the if condition block, you correctly use depositTokenAmountAdd_ and rewardTokenAmountAdd_, but in the subsequent else block, you mistakenly use rewardTokenAmountAdd_ as amountAdd0_ and depositTokenAmountAdd_ as amountAdd1_.

Impact

The incorrect input values in the function may lead to a revert and making the function unusable.

Tools Used

Manual Review

Recommendations

You might want to update the internal variable names to match the external parameter names like this:

This correction ensures that the internal variable names align with the corresponding external parameter names, resolving the discrepancy.