Summary

Consider bounding input array length

Vulnerability Details

Impact

If the number of for loop iterations is unbounded, then it may lead to the transaction to run out of gas. While the function will revert if it eventually runs out of gas.

Tools Used

Manual Review

Recommendations

It may be a nicer user experience to require() that the length of the array is below some reasonable maximum, so that the user doesn't have to use up a full transaction's gas only to see that the transaction reverts.