There is an issue in the inline assembly code within the IS_HAPPY_HORSE
macro. The current code fails to correctly handle the case where timestamp
is equal to horseFedTimestamp
, resulting in an incorrect return value.
The issue arises in the following portion of the code:
The code incorrectly jumps to the start_return_true label only if timestamp
is not equal to horseFedTimestamp
, leading to an incorrect result when they are equal.
This vulnerability could lead to incorrect evaluation of whether a horse is happy or not. In particular, when timestamp
matches horseFedTimestamp
, the current code incorrectly returns false, contrary to the expected behavior.
Manual review.
It is recommended to modify the code to handle the case where timestamp
is equal to horseFedTimestamp
correctly.
Update code will look like this:
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.