Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

`HorseStore.huff` doesn't implement all the functionality of `HorseStore.sol`, causing both contracts not to be equivalent

Description

According to the documentation:

Every function in the solidity rendition has been re-written in huff

However this is not the case. Important inherited functions in HorseStore.sol are missing in HorseStore.huff

For example ERC721Enumerable.sol::tokenOfOwnerByIndex has no equivalent in HorseStore.huff.

Impact

HorseStore.sol and HorseStore.huff cannot be considered equivalent, contradicting the documentation.

HorseStore.huff does not provide the required functionality.

Proof of concept

No tokenOfOwnerByIndex function defined in HorseStore.huff::MAIN.

Recommended mitigation

Implement the missing features in HorseStore.huff.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Components of ERC721 not properly (or at all) implemented in HUFF

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.