Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Horse ID Check

Summary

The functions feedHorse() and isHappyHorse() do not have anything to check whether or not the provided ID exists.

Vulnerability Details

This could lead to wasted transactions.

Impact

This is a low-risk vulnerability because it is not related to any funds.

Tools Used

I used unit tests to find that missing check.

Recommendations

As I have done in the provided GitHub link, my recommendation would be to add a modifier that checks whether or not the provided ID exists.

Updates

Lead Judging Commences

inallhonesty Lead Judge
over 1 year ago
inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Nonexistent horses can be fed

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.