First Flight #7: Horse Store

Summary

All 3 functions, GET_HORSE_FED_TIMESTAMP,FEED_HORSE and IS_HAPPY_HORSE only hash the horseId variable when trying to load the value of the mapping horseIdToFedTimeStamp. This will result in loading another value from storage rather than the mapping.

Vulnerability Details

These three functions attempt to read the mapping horseIdToFedTimeStamp but fail to hash the correct values to recover it's correct slot.

Impact

This will cause issues as the values that will be loaded/modified would be from another slot in storage.
A main property of the contract will thus be completely wrong and exposed, as the state of happiness of the horse might always be true or false.

Tools Used

Manual review

Recommendations

Need to load both the mapping location and horseId before hashing both.

#define constant HORSEIDTOTIMESTAMP_LOCATION= add correct slot here