Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

Huff Version Missing Function Implementations

Summary

There are a few inconsistencies between the Solidity and the Huff versions of the HorseStore contracts.

The following are not implemented in the Huff version:

  • safeTransferFrom(): this function is completely missing. Only transferFrom() is available.

  • tokenOfOwnerByIndex(): this function is completely missing

  • tokenByIndex(): this function is completely missing

  • _safeMint(): meaning the logic to check whether the recipient can manage ERC721s is not implemented (even though it is present in the Solidity version).

Impact

Users of the Huff version will not be able to use the mentioned functions.

Tools Used

Foundry and manual analysis.

Recommendations

It is recommended to implement the functions above to make sure the Solidity and Huff versions are equivalent.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Components of ERC721 not properly (or at all) implemented in HUFF

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.