Submission Details
Severity:
In the Horse Store Huff contract the total supply not incremented causes paused horse NFT minting
Summary
The total supply is not incremented in horse store huff contract which will pause the minting of NFT and not allows user to mint more NFTs.
Impact
User can't mint horse.
PoC
forge test --mt test_HorseIsMintedButTotalSupplyNotIncremented
function test_HorseIsMintedButTotalSupplyNotIncremented() public {
uint256 totalSupply = horseStore.totalSupply();
vm.prank(user);
horseStore.mintHorse();
uint256 tokenSupplyAfterMintingHorse = horseStore.totalSupply();
assertEq(tokenSupplyAfterMintingHorse, totalSupply);
address alice = makeAddr("alice");
vm.prank(alice);
vm.expectRevert();
horseStore.mintHorse();
}
Tools Used
Manual Review
Recommendations
Increment the total supply after each nft mint.
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Failure to increment total supply on mint
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.