Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

No `SafeTransferFrom` in `HorseStore.huff`

Description

HorseStore.huff doesn't implement the safeTransferFrom macro, which is available in HorseStore.sol. This function is useful for other contracts that want to receive this ERC721.

Impact

Non-compliance with Solidity contract standards. It prevents the use of HorseStore.huff with other contracts that expect to interact with a standard ERC721 implementation.

Recommended Mitigation

Consider using the huffmate/token/ERC721 library instead of manually implementing ERC721 functions in HorseStore.huff. The library is likely to provide a standardized and safer implementation of ERC721, including safeTransferFrom, making the contract more interoperable with other contracts and compliant with industry standards.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Components of ERC721 not properly (or at all) implemented in HUFF

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.