First Flight #7: Horse Store
First Flight #7
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing functions in `IHorseStore.sol`

n0kto

Description

The IHorseStore.sol interface is missing two functions to access the public mapping horseIdToFedTimeStamp and the public constant HORSE_HAPPY_IF_FED_WITHIN.

Impact

Contract or users utilizing this interface ABI won't be able to easily read these storage variables. Accessing the ABI is one of the main purposes of an interface.

Recommended Mitigation

interface IHorseStore is IERC721Enumerable {
​
+ function HORSE_HAPPY_IF_FED_WITHIN() public view returns (uint256);
​
+ function horseIdToFedTimeStamp(uint256) public view returns (uint256);
​
function mintHorse() external;
​
function feedHorse(uint256 horseId) external;
​
function isHappyHorse(uint256 horseId) external view returns (bool);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.