Submission Details
Severity:
`HorseStore.sol::HorseStore::isHappyHorse` returns false even if horse is happy.
Summary
It is given that - ''If horse has been fed within the past 24 hours, horse X must be happy."
But in the function it returns false for boundary condition.
Vulnerability Details
The vulnerability lies in the solidity contract isHappyHorse function where it returns false for boundary condition but it should be true.
Impact
Returns false even if horse is happy for boundary condition.
Tools Used
Manual Review
Recommendations
Make the below updations
function isHappyHorse(uint256 horseId) external view returns (bool) {
- if (horseIdToFedTimeStamp[horseId] <= block.timestamp - HORSE_HAPPY_IF_FED_WITHIN) {
+ if (horseIdToFedTimeStamp[horseId] < block.timestamp - HORSE_HAPPY_IF_FED_WITHIN) {
return false;
}
return true;
}
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.