Submission Details
Severity:
`HorseStore.huff::FEED_HORSE` reverts if the timestamp is a multiple of 17, which doesn't allow to feed horses at all times
Description
According to the doc
Horses must be able to be fed at all times.
However, the code checks if the timestamp is a multiple of 17 (0x11) and reverts if this is the case.
...
// End execution
0x11 timestamp mod
endFeed jumpi
revert
endFeed:
stop
}
Impact
Horses can't be fed at all times, which doesn't respect the documentation.
Proof of concept
function testFeedingHorseUpdatesTimestamps(uint256 timestamp) public {
uint256 horseId = horseStore.totalSupply();
vm.prank(user);
horseStore.mintHorse();
vm.warp(timestamp);
vm.roll(timestamp);
uint256 lastFedTimeStamp = block.timestamp;
horseStore.feedHorse(horseId);
uint256 recordedLastFedTimeStamp = horseStore.horseIdToFedTimeStamp(horseId);
assertEq(recordedLastFedTimeStamp, lastFedTimeStamp);
}
results in
Running 6 tests for test/HorseStoreHuff.t.sol:HorseStoreHuff
[FAIL. Reason: EvmError: Revert; counterexample: calldata=0x3fc2d716ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff args=[115792089237316195423570985008687907853269984665640564039457584007913129639935 [1.157e77]]] testFeedingHorseUpdatesTimestamps(uint256) (runs: 263, μ: 106029, ~: 106029)
with the timestamp being a multiple of 17
115792089237316195423570985008687907853269984665640564039457584007913129639935 % 17
0
Recommended mitigation
Remove the lines causing the FEED_HORSE function to revert depending on the timestamp
// End execution
- 0x11 timestamp mod
- endFeed jumpi
- revert
- endFeed:
stop
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
FEED_HORSE() macro does not allow users to feed a horse if the timestamp is divisible by 17
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.