Submission Details
Severity:
Contracts using Solidity version 0.8.3 will not compile
Summary
The version pragma indicates that the library will be valid for versions 0.8.3 or higher and below 0.9.0, but it is not compatible with 0.8.3.
Vulnerability Details
The library is using custom errors, but that functionality was introduced in 0.8.4, so it will not compile with 0.8.3.
// SPDX-License-Identifier: MIT
// @notice We intentionally want to leave this as floating point so others can use it as a library.
pragma solidity ^0.8.3;
Impact
Contracts that require Soldity 0.8.3 will not be able to use this library.
Tools Used
Manual review
Proof of Concept
Set the compiler version to 0.8.3 in the tests and try to run.
MathMasters.t.sol
// SPDX-License-Identifier: MIT
// @notice We intentionally want to leave this as floating point so others can use it as a library.
pragma solidity 0.8.3;
forge test
...
Compiler run failed:
Error (2314): Expected ';' but got '('
--> src/MathMasters.sol:14:41:
|
14 | error MathMasters__FactorialOverflow();
| ^
Recommended Mitigation
Change the version pragma to ^0.8.4 and indicate this change in the documentation.
MathMasters.sol
// SPDX-License-Identifier: MIT
// @notice We intentionally want to leave this as floating point so others can use it as a library.
-pragma solidity ^0.8.3;
+pragma solidity ^0.8.4;
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Project that use pragma=0.8.3 won't be able to use the library due to custom errors not being supported in that Solidity version.
Rewards breakdown
nSLOC
46This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.