Summary

Incorrect use of function selector for reverts

Vulnerability Details

In function mulWad and mulWadUp reverts are shown with function selector 0xbac65e5b which is not the correct value if we check it for MathMasters__MulWadFailed() .
We can verify it easily by running following command in foundry.

cast sig 'MathMasters__MulWadFailed()'

we will get following output.

0xa56044f7

0xa56044f7 is the correct value, which needs to be used.

Impact

Wrong / unknown function selector could lead to confusions.

Tools Used

Manual Review / Foundry

Recommendations

Replace 0xbac65e5b with 0xa56044f7 in codebase.