Summary

The issue involves the usage of an incorrect function selector for the MathMasters__MulWadFailed() custom error. The current selector is 0xbac65e5b, but the correct one is 0xa56044f7. This inconsistency may lead to confusion and potential errors in error handling.

Vulnerability Details

The mulWad function in the MathMasters library has an incorrect function selector for the MathMasters__MulWadFailed() custom error. The incorrect selector 0xbac65e5b is used, while the correct selector is 0xa56044f7.

Impact

The incorrect function selector could result in misinterpretation and misidentification of the error during execution. Developers relying on the accurate identification of errors may encounter challenges in handling this specific error case.

POC

• When I run forge inspect MathMasters errors I get the below result for MathMasters__MulWadFailed but the currently used one is wrong.

Recommendations

It is recommended to update the function selector in the mulWad function to the correct one (0xa56044f7). This ensures consistency and accuracy in error handling. Additionally, a thorough review of other function selectors in the library is advised to verify their correctness.