Submission Details
Severity:
Emit incorrect error
Vulnerability Details
Error selector 0xbac65e5b is the encode of error MulWadFailed(), not the MathMasters__MulWadFailed() in comment.
Tools Used
Manual.
Recommendations
bytes4 selector = MathMasters__MulWadFailed.selector;
assembly {
...
mstore(0x40, selector)
...
}
PoC
// SPDX-License-Identifier: MIT
import "forge-std/Test.sol";
import {MathMasters} from "../src/MathMasters.sol";
contract IncorrectErrorSelector is Test {
// error for mulWad and mulWadUp
error MulWadFailed();
// success
function test_es_mulwad() external {
vm.expectRevert(MulWadFailed.selector);
MathMasters.mulWad(type(uint256).max, type(uint256).max);
}
}
Updates
Lead Judging Commences
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
Wrong error selector
Rewards breakdown
nSLOC
46This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.