Submission Details
Severity:
Deletion on mapping containing a structure
Summary
A deletion in a structure containing a mapping will not delete the mapping (see the Solidity documentation). The remaining data may be used to compromise the contract.
Vulnerability Details
File: contracts/mocks/mockFacets/MockSeasonFacet.sol
/// @audit ******************* Issue Detail *******************
MockSeasonFacet.resetState() (contracts/mocks/mockFacets/MockSeasonFacet.sol#228-255) deletes Storage.Governance (contracts/beanstalk/AppStorage.sol#249-255) which contains a mapping:
-delete s.g (contracts/mocks/mockFacets/MockSeasonFacet.sol#243)
/// @audit ************** Possible Issue Line(s) **************
L#243,
/// @audit ****************** Affected Code *******************
243: delete s.g;
Tools Used
Manual Aided Review
Recommendations
Use a lock mechanism instead of a deletion to disable structure containing a mapping.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Out of scope
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.