Submission Details
Severity:
Comparing to a Boolean constant
Summary
Comparison to boolean constants can be avoided and variable can be used directly in the conditional statement (saves some gas).
Vulnerability Details
File: contracts/libraries/LibEvaluate.sol
/// @audit ******************* Issue Detail *******************
LibEvaluate.calcLPToSupplyRatio(uint256) (contracts/libraries/LibEvaluate.sol#208-266) compares to a boolean constant:
- LibAppStorage.diamondStorage().season.fertilizing == true (contracts/libraries/LibEvaluate.sol#251)
/// @audit ************** Possible Issue Line(s) **************
L#251,
/// @audit ****************** Affected Code *******************
251: if (LibAppStorage.diamondStorage().season.fertilizing == true) {
GitHub : 208-266
Impact
Unnecessary use of gas by comparing to bool value.
Tools Used
Manual Review
Recommendations
Consider using if(directValue) instead of if(directValue == true) and if(!directValue) instead of if(directValue == false)
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.