Beanstalk Part 1
Beanstalk
DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Dead code

CryptoThemeX

Summary

Code has Functions that are never used.

Vulnerability Details

File: contracts/libraries/Silo/LibGerminate.sol
​
/// @audit ******************* Issue Detail *******************
LibGerminate.getUnclaimedGerminatingStalkAndRoots(uint32) (contracts/libraries/Silo/LibGerminate.sol#319-324) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
319: function getUnclaimedGerminatingStalkAndRoots(
320: uint32 season
321: ) internal view returns (Storage.Sr memory unclaimed) {
322: AppStorage storage s = LibAppStorage.diamondStorage();
323: unclaimed = s.unclaimedGerminating[season];
324: }

GitHub : 319-324

File: contracts/beanstalk/silo/SiloFacet/SiloGettersFacet.sol
​
/// @audit ******************* Issue Detail *******************
SiloGettersFacet._season() (contracts/beanstalk/silo/SiloFacet/SiloGettersFacet.sol#584-586) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
584: function _season() internal view returns (uint32) {
585: return s.season.current;
586: }

GitHub : 584-586

File: contracts/libraries/Silo/LibTokenSilo.sol
​
/// @audit ******************* Issue Detail *******************
LibTokenSilo.incrementTotalGerminatingBdv(address,uint256,LibGerminate.Germinate) (contracts/libraries/Silo/LibTokenSilo.sol#173-202) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
173: function incrementTotalGerminatingBdv(
174: address token,
175: uint256 bdv,
176: LibGerminate.Germinate germ
177: ) internal {
178: AppStorage storage s = LibAppStorage.diamondStorage();
179:
180: if (germ == LibGerminate.Germinate.ODD) {
181: // increment odd germinating
182: s.oddGerminating.deposited[token].bdv = s.oddGerminating.deposited[token].bdv.add(

GitHub : 173-202

File: contracts/libraries/Silo/LibSilo.sol
​
/// @audit ******************* Issue Detail *******************
LibSilo.burnStalk(address,uint256,LibGerminate.Germinate) (contracts/libraries/Silo/LibSilo.sol#230-250) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
230: function burnStalk(address account, uint256 stalk, LibGerminate.Germinate germ) internal {
231: AppStorage storage s = LibAppStorage.diamondStorage();
232: if (stalk == 0) return;
233:
234: // increment user and total stalk and roots if not germinating:
235: if (germ == LibGerminate.Germinate.NOT_GERMINATING) {
236: uint256 roots = burnActiveStalk(account, stalk);
237:
238: // Oversaturated was previously referred to as Raining and thus
239: // code references mentioning Rain really refer to Oversaturation
240: // If Beanstalk is Oversaturated, subtract Roots from both the
241: // account's and Beanstalk's Oversaturated Roots balances.
242: // For more info on Oversaturation, See {Weather.handleRain}
243: if (s.season.raining) {
244: s.r.roots = s.r.roots.sub(roots);
245: s.a[account].sop.roots = s.a[account].roots;
246: }
247: } else {
248: burnGerminatingStalk(account, uint128(stalk), germ);
249: }
250: }

GitHub : 230-250

File: contracts/libraries/Silo/LibTokenSilo.sol
​
/// @audit ******************* Issue Detail *******************
LibTokenSilo.calculateStalkFromStemAndBdv(address,int96,uint256) (contracts/libraries/Silo/LibTokenSilo.sol#553-562) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
553: function calculateStalkFromStemAndBdv(
554: address token,
555: int96 grownStalkIndexOfDeposit,
556: uint256 bdv
557: ) internal view returns (int96 grownStalk) {
558: // current latest grown stalk index
559: int96 _stemTipForToken = stemTipForToken(address(token));
560:
561: return _stemTipForToken.sub(grownStalkIndexOfDeposit).mul(toInt96(bdv));
562: }

GitHub : 553-562

File: contracts/libraries/Silo/LibLegacyTokenSilo.sol
​
/// @audit ******************* Issue Detail *******************
LibLegacyTokenSilo.incrementMigratedBdv(address,uint256) (contracts/libraries/Silo/LibLegacyTokenSilo.sol#548-551) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
548: function incrementMigratedBdv(address token, uint256 bdv) private {
549: AppStorage storage s = LibAppStorage.diamondStorage();
550: s.migratedBdvs[token] = s.migratedBdvs[token].add(bdv);
551: }

GitHub : 548-551

File: contracts/libraries/LibUnripe.sol
​
/// @audit ******************* Issue Detail *******************
LibUnripe._getTotalPenalizedUnderlying(address) (contracts/libraries/LibUnripe.sol#157-163) is never used and should be removed
​
/// @audit ****************** Affected Code *******************
157: function _getTotalPenalizedUnderlying(
158: address unripeToken
159: ) internal view returns (uint256 redeem) {
160: require(isUnripe(unripeToken), "not vesting");
161: uint256 supply = IERC20(unripeToken).totalSupply();
162: redeem = _getUnderlying(unripeToken, getRecapPaidPercentAmount(supply), supply);
163: }

GitHub : 157-163

Impact

Unused code cause unnecessary compilation, gas overhead and codebase maintenance issues.

Tools Used

Manual Review

Recommendations

Remove unused functions.

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.