DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

Unsafe ABI Encoding

Summary

abi.encodeWithSelector is used in below files generate calldata for a low-level call. abi.encodeWithSelector is not type-safe and this method is error-prone and should be considered unsafe.

  • LibWhitelist function verifyGaugePointSelector

  • LibEvaluate function getLiquidityWeight

  • LibTokenSilo function encodeBdvFunction

  • and LibGauge function calcGaugePoints

Recommendations

Consider replacing all instances of unsafe ABI encoding with abi.encodeCall . It checks whether the supplied values actually match the types expected by the called function and also avoids errors caused by typos.

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.