Submission Details
Severity:
ConvertFacet::convert Miss check for toAmount is grater then zero
Summary
It not critical error it more like informative or gas because it's try to check toAmount > zero but check fromAmount twice.
Vulnerability Details
waste of gas if toAmount < zero just revert instead of run all transaction and revert in the end
Impact
waste of gas
Tools Used
Manual Review
Recommendations
- require(fromAmount > 0, "Convert: From amount is 0.");
+ require(toAmount > 0, "Convert: To amount is 0.");
require(fromAmount > 0, "Convert: From amount is 0.");
LibSilo._mow(msg.sender, fromToken);
LibSilo._mow(msg.sender, toToken);
(grownStalk, fromBdv) = _withdrawTokens(
fromToken,
stems,
amounts,
fromAmount
);
Updates
Lead Judging Commences
giovannidisiena about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Convert validation
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.