DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

DOS for user during picking unripe tokens

Summary

The picked function checks if an unripe token has been picked by a user but failed to consider the amount of unripe tokens picked which means a user cannot pick unripe tokens if the user pick a percentage of the unripe tokens.

Vulnerability Details

this line of code below disallows a user picking unripe tokens.

require(!picked(msg.sender, token), "UnripeClaim: already picked");

In the full function calling the above line, amount is an input to allow the user to specify the amount of unrip tokens to pick. If a user decides to pick 50% of his allocation he potentially could lose the rest of the unripe token as he is unable to pick the rest of the token but could use other functions to use the rest of the unripe tokens

Impact

  • DOS on the picking function after first-time usage

  • Potential loss of funds

Tools Used

Foundry, Manual Review

Recommendations

  • Instead of tracking a picked user, track the amount of picked tokens against users.

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.