Submission Details
Severity:
Cross Contract reentrancy between `SiloFacet` and `Silo`
Summary
Cross Contract reentrancy
Vulnerability Details
The account state avariable in _claimPlenty is updated after the transfer, this can lead to reentrancy
Impact
users can claim more funds than they deposited . Also be used to steal funds
Tools Used
manual
Recommendations
-
Use check effect interaction when making transfers
-
make this code changes
function _claimPlenty(address account) internal {
// Plenty is earned in the form of the sop token.
uint256 plenty = s.a[account].sop.plenty;
IWell well = IWell(s.sopWell);
IERC20[] memory tokens = well.tokens();
IERC20 sopToken = tokens[0] != C.bean() ? tokens[0] : tokens[1];
+ delete s.a[account].sop.plenty;
- sopToken.safeTransfer(account, plenty);
emit ClaimPlenty(account, address(sopToken), plenty);
}
Updates
Lead Judging Commences
giovannidisiena about 1 year ago
Submission Judgement Published Reason: Incorrect statement
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.