DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

Possible rounding issue

Summary

Division by large numbers may result in the result being zero, due to solidity not supporting fractions.

Vulnerability Details

Affected code:

underlying = s.u[unripeToken].balanceOfUnderlying.mul(unripe).div(supply);

Impact

result may end up being zero

Tools Used

Manual Review

Recommendations

Consider requiring a minimum amount for the numerator to ensure that it is always larger than the denominator

Updates

Lead Judging Commences

giovannidisiena Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.