Submission Details
Severity:
`convertKind` is not checking if the return value `kind` is valid or not
Summary
In the convertKind function, consider adding a default case to handle potential errors or unexpected values. This helps ensure that the function can gracefully handle future modifications to the enum. or even if someone passed a wrong kind so it will return a graceful error rather then returning something weird.
Recommendations
Add this check
/// @notice Decoder for the Convert Enum
function convertKind(bytes memory self) internal pure returns (ConvertKind) {
ConvertKind kind = abi.decode(self, (ConvertKind));
+ require(kind <= ConvertKind.UNRIPE_TO_RIPE, "Invalid ConvertKind");
+ return kind;
}
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.