DeFiHardhatOracleProxyUpdates
100,000 USDC
View results
Submission Details
Severity: low
Invalid

Incorrect cast on season paramater on LibGerminate::TotalGerminatingBalanceChanged

Summary

The event TotalGerminatingBalanceChanged have the first parameter defines as season which is cast as uint256. However, when this event are emitted, the variable used is uint32

Impact

This type cast error won't cause functionally issue, it will be more gas efficient to cast season parameter as uint32

Recommendations

Change cast of season parameter from uint256 to uint32 on event TotalGerminatingBalanceChanged

- event TotalGerminatingBalanceChanged(uint256 season,address indexed token,int256 delta,int256 deltaBdv );
+ event TotalGerminatingBalanceChanged(uint32 season,address indexed token,int256 delta,int256 deltaBdv );
Updates

Lead Judging Commences

giovannidisiena Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational/Invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.