Beanstalk Part 1

Vulnerability Details

The endAccountGermination function transitions an account's germinating stalk and roots to active balances. It uses lastMowedSeason and currentSeason parameters to determine the transition period. The function currently lacks validation checks for these parameters.

Impact

The omission of parameter validation could precipitate a spectrum of non-conformant behaviors, such as:

1. Activation of germinating values for out-of-sequence seasons, leading to incorrect ledger entries for stalk and root balances.

2. Unintended state mutations resulting from operations based on invalid season parameters, causing systemic discrepancies in germination tracking.

Tools Used

manual review

Recommendations

1. Verifying that currentSeason is not less than lastMowedSeason, ensuring chronological consistency.

2. Ensuring that currentSeason is within the upper boundary of the contract's seasonality framework

3. Confirming that lastMowedSeason meets or exceeds the lower boundary of the contract's seasonality framework.