First Flight #10: One Shot

Summary

In the README.md file the arithmetic said to be implemented is a base skill of 50 is applied to all rappers in battle, and this is modified by the properties the rapper holds.

• WeakKnees - False = +5

• HeavyArms - False = +5

• SpaghettiSweater - False = +5

• CalmAndReady - True = +10

Whereas the Logic in RapBattle.sol is a base skill of 65 that decrements on true

• WeakKness - True = -5

• HeavyArms - True = -5

• SpaghettiSweater - True = -5

• CalmAndReady - True = +10

Vulnerability Details

Different arithmetic in the README.md file and the logic implemented RapBattle::getRapperSkill(uint256 _tokenId). README.md base is 50, where as RapBattle.sol is 65.

Recommendations

change logic to follow README.md or update readme to follow logic.