First Flight #10: One Shot

When writing require or if conditionals that check storage values, it is important to be consistent to prevent off-by-one errors. There are instances found where the same storage variable is checked multiple times, but the conditionals are not consistent.

• Found in src/RapBattle.sol Line: 56

  require(defenderBet == _credBet, "RapBattle: Bet amounts do not match");

• Found in src/RapBattle.sol Line: 60

  uint256 totalPrize = defenderBet + _credBet;