Submission Details
Severity:
[I-1] `RapBattle::goOnStageOrBattle()` allows to bet 0 CRED
Description
RapBattle::goOnStageOrBattle() does not check if _credBet is more than 0. A bet of 0 only end up spending gas without a possibility of rewards which defeats the purpose of rap battle betting
Recommended Mitigation
function goOnStageOrBattle(uint256 _tokenId, uint256 _credBet) external {
if (defender == address(0)) {
+ require(_credBet > 0, "RapBattle: Bet amounts is 0");
defender = msg.sender;
defenderBet = _credBet;
defenderTokenId = _tokenId;
emit OnStage(msg.sender, _tokenId, _credBet);
oneShotNft.transferFrom(msg.sender, address(this), _tokenId);
credToken.transferFrom(msg.sender, address(this), _credBet);
} else {
// credToken.transferFrom(msg.sender, address(this), _credBet);
_battle(_tokenId, _credBet);
}
}
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.