First Flight #10: One Shot

Description

The documentation for RapBattle.sol states that a base skill of 50 is applied to all the rappers in battle, this is in direct contrast with the value of the BASE_SKILL variable which is set to 65 in the contract code.

Documentation:
"Users can put their Cred on the line to step on stage and battle their Rappers. A base skill of 50 is applied to all rappers in battle, and this is modified by the properties the rapper holds."

Contract Code:

It can be observed in RapBattle::getRapperSkill that each vice costs the rapper a VICE_DECREMENT of value 5. Although this ensures that the initial base skill value for each NFT is 50, it can cause confusion for the users.

Impact

It can cause confusion for users as they might go by the docs and assume the base skill level to be 50 but will find discrepancies while battling their NFTs.

Recommended Mitigation

Please make documentation and code consistent with each other.