Submission Details
Severity:
`battlesWon` is never updated and used.
Summary
In the _battle function the battlesWon in RapperStats struct is never updated.
Vulnerability Details
If battlesWon is never used or updated it is better to be removed from the struct as it costs unnecessary gas. Or it should be implemented in the _battle function and in the calculation of the strength of the Rapper.
Impact
Low as battlesWon is not used anywhere.
Tools Used
Manual review
Recommendations
After a battle increment the battlesWon variable for the winner.
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
`battlesWon` is never updated
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.