Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

L-1: No duplicate checks for tokenId in goOnStageOrBattle function

Summary

The _battle function allows the same NFT tokenId to be used as both the defender and the challenger, potentially leading to unfair advantages and system logic disruption.

Vulnerability Details

Missing Validation: There's no check to prevent identical tokenId values from being used in a single battle by the defender and challenger.

Impact

Potential for DoS: An attacker can disrupt the availability of the battle system for others.

Tools Used

Manual review

Recommendations

+ require(defenderTokenId != _tokenId, "Cannot use the same NFT as defender and challenger");
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

It's YOU vs YOU

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.