Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Wrong event argument emitted

Summary

Wrong winner emitted with Battle event in RapBattle contract

Vulnerability Details

In case if random equals defenderRapperSkill msg.sender become winner for event but they will loose tokens because they didn't defeat defender according function logic

Impact

On frontend it could lead to misunderstanding for challenger

Tools Used

Manual testing with Remix

Recommendations

Change < to <= in the line 76 in RapBattle contract

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Contradictory battle result event

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.