Submission Details
Severity:
event is emiting a losser as a winner when `random == defenderRapperSkill`
Summary
when
random == defenderRapperSkillthe event is emiting a losser as a winner which can create conficts
Vulnerability Details
In
RapBattle.solthebattlefunction is emitting aBattleevent withwinner. but, whenrandom == defenderRapperSkillthe event is emiting a losser as a winner which can create conficts
@> emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
Impact
this can create conficts in the battle result
Off-chain systems that rely on the event logs to determine the outcome of the battle may be affected
Tools Used
manual review
Recommendations
Create this change to emit the correct winner
- emit Battle(msg.sender, _tokenId, random < defenderRapperSkill ? _defender : msg.sender);
+ emit Battle(msg.sender, _tokenId, random <= defenderRapperSkill ? _defender : msg.sender);
Updates
Lead Judging Commences
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
Contradictory battle result event
Rewards breakdown
nSLOC
201This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.